Jona123/NPCLib
0
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fixed issue for when NPC is spawned onJoin.

Browse Source 
Skin was not showing because the PacketPlayOutPlayerInfo (remove) was sent too early. Delay this by a factor of 10 to prevent this.
This commit is contained in:
JitseB
2018-05-14 22:09:16 +02:00
parent 3120613f85
commit e0862fcfb6
9 changed files with 23 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files
nms/v1_10_R1/src/main/java/net/jitse/npclib/nms/v1_10_R1/NPC_v1_10_R1.java
+2 -5
View File
@@ -13,7 +13,6 @@ import net.jitse.npclib.nms.v1_10_R1.packets.PacketPlayOutScoreboardTeamWrapper;
import net.jitse.npclib.skin.Skin;
import net.minecraft.server.v1_10_R1.*;
import org.bukkit.Bukkit;
import org.bukkit.Location;
import org.bukkit.craftbukkit.v1_10_R1.entity.CraftPlayer;
import org.bukkit.entity.Player;
import org.bukkit.plugin.java.JavaPlugin;
@@ -37,9 +36,7 @@ public class NPC_v1_10_R1 extends NPC {
}
@Override
public void create(Location location) {
this.location = location;
public void createPackets() {
this.hologram = new Hologram(location.clone().subtract(0, 0.5, 0), lines);
hologram.generatePackets(true);
@@ -84,7 +81,7 @@ public class NPC_v1_10_R1 extends NPC {
Bukkit.getScheduler().runTaskLater(plugin, () ->
playerConnection.sendPacket(packetPlayOutPlayerInfoRemove), 5);
playerConnection.sendPacket(packetPlayOutPlayerInfoRemove), 50);
}
@Override
nms/v1_11_R1/src/main/java/net/jitse/npclib/nms/v1_11_R1/NPC_v1_11_R1.java
+2 -5
View File
@@ -13,7 +13,6 @@ import net.jitse.npclib.nms.v1_11_R1.packets.PacketPlayOutScoreboardTeamWrapper;
import net.jitse.npclib.skin.Skin;
import net.minecraft.server.v1_11_R1.*;
import org.bukkit.Bukkit;
import org.bukkit.Location;
import org.bukkit.craftbukkit.v1_11_R1.entity.CraftPlayer;
import org.bukkit.entity.Player;
import org.bukkit.plugin.java.JavaPlugin;
@@ -37,9 +36,7 @@ public class NPC_v1_11_R1 extends NPC {
}
@Override
public void create(Location location) {
this.location = location;
public void createPackets() {
this.hologram = new Hologram(location.clone().add(0, 0.5, 0), lines);
hologram.generatePackets(true);
@@ -84,7 +81,7 @@ public class NPC_v1_11_R1 extends NPC {
Bukkit.getScheduler().runTaskLater(plugin, () ->
playerConnection.sendPacket(packetPlayOutPlayerInfoRemove), 5);
playerConnection.sendPacket(packetPlayOutPlayerInfoRemove), 50);
}
@Override
nms/v1_12_R1/src/main/java/net/jitse/npclib/nms/v1_12_R1/NPC_v1_12_R1.java
+2 -5
View File
@@ -13,7 +13,6 @@ import net.jitse.npclib.nms.v1_12_R1.packets.PacketPlayOutScoreboardTeamWrapper;
import net.jitse.npclib.skin.Skin;
import net.minecraft.server.v1_12_R1.*;
import org.bukkit.Bukkit;
import org.bukkit.Location;
import org.bukkit.craftbukkit.v1_12_R1.entity.CraftPlayer;
import org.bukkit.entity.Player;
import org.bukkit.plugin.java.JavaPlugin;
@@ -37,9 +36,7 @@ public class NPC_v1_12_R1 extends NPC {
}
@Override
public void create(Location location) {
this.location = location;
public void createPackets() {
this.hologram = new Hologram(location.clone().add(0, 0.5, 0), lines);
hologram.generatePackets(true);
@@ -84,7 +81,7 @@ public class NPC_v1_12_R1 extends NPC {
Bukkit.getScheduler().runTaskLater(plugin, () ->
playerConnection.sendPacket(packetPlayOutPlayerInfoRemove), 5);
playerConnection.sendPacket(packetPlayOutPlayerInfoRemove), 50);
}
@Override
nms/v1_8_R1/src/main/java/net/jitse/npclib/nms/v1_8_R1/NPC_v1_8_R1.java
+1 -1
View File
@@ -80,7 +80,7 @@ public class NPC_v1_8_R1 extends NPC {
hologram.spawn(player);
Bukkit.getScheduler().runTaskLater(plugin, () ->
playerConnection.sendPacket(packetPlayOutPlayerInfoRemove), 5);
playerConnection.sendPacket(packetPlayOutPlayerInfoRemove), 50);
}
@Override
nms/v1_8_R2/src/main/java/net/jitse/npclib/nms/v1_8_R2/NPC_v1_8_R2.java
+2 -6
View File
@@ -13,7 +13,6 @@ import net.jitse.npclib.nms.v1_8_R2.packets.PacketPlayOutScoreboardTeamWrapper;
import net.jitse.npclib.skin.Skin;
import net.minecraft.server.v1_8_R2.*;
import org.bukkit.Bukkit;
import org.bukkit.Location;
import org.bukkit.craftbukkit.v1_8_R2.entity.CraftPlayer;
import org.bukkit.entity.Player;
import org.bukkit.plugin.java.JavaPlugin;
@@ -37,9 +36,7 @@ public class NPC_v1_8_R2 extends NPC {
}
@Override
public void create(Location location) {
this.location = location;
public void createPackets() {
this.hologram = new Hologram(location.clone().add(0, 0.5, 0), lines);
hologram.generatePackets(false);
@@ -82,9 +79,8 @@ public class NPC_v1_8_R2 extends NPC {
hologram.spawn(player);
Bukkit.getScheduler().runTaskLater(plugin, () ->
playerConnection.sendPacket(packetPlayOutPlayerInfoRemove), 5);
playerConnection.sendPacket(packetPlayOutPlayerInfoRemove), 50);
}
@Override
nms/v1_8_R3/src/main/java/net/jitse/npclib/nms/v1_8_R3/NPC_v1_8_R3.java
+2 -5
View File
@@ -13,7 +13,6 @@ import net.jitse.npclib.nms.v1_8_R3.packets.PacketPlayOutScoreboardTeamWrapper;
import net.jitse.npclib.skin.Skin;
import net.minecraft.server.v1_8_R3.*;
import org.bukkit.Bukkit;
import org.bukkit.Location;
import org.bukkit.craftbukkit.v1_8_R3.entity.CraftPlayer;
import org.bukkit.entity.Player;
import org.bukkit.plugin.java.JavaPlugin;
@@ -37,9 +36,7 @@ public class NPC_v1_8_R3 extends NPC {
}
@Override
public void create(Location location) {
this.location = location;
public void createPackets() {
this.hologram = new Hologram(location.clone().add(0, 0.5, 0), lines);
hologram.generatePackets(false);
@@ -84,7 +81,7 @@ public class NPC_v1_8_R3 extends NPC {
Bukkit.getScheduler().runTaskLater(plugin, () ->
playerConnection.sendPacket(packetPlayOutPlayerInfoRemove), 5);
playerConnection.sendPacket(packetPlayOutPlayerInfoRemove), 50);
}
@Override
nms/v1_9_R1/src/main/java/net/jitse/npclib/nms/v1_9_R1/NPC_v1_9_R1.java
+2 -5
View File
@@ -13,7 +13,6 @@ import net.jitse.npclib.nms.v1_9_R1.packets.PacketPlayOutScoreboardTeamWrapper;
import net.jitse.npclib.skin.Skin;
import net.minecraft.server.v1_9_R1.*;
import org.bukkit.Bukkit;
import org.bukkit.Location;
import org.bukkit.craftbukkit.v1_9_R1.entity.CraftPlayer;
import org.bukkit.entity.Player;
import org.bukkit.plugin.java.JavaPlugin;
@@ -37,9 +36,7 @@ public class NPC_v1_9_R1 extends NPC {
}
@Override
public void create(Location location) {
this.location = location;
public void createPackets() {
this.hologram = new Hologram(location.clone().subtract(0, 0.5, 0), lines);
hologram.generatePackets(false);
@@ -84,7 +81,7 @@ public class NPC_v1_9_R1 extends NPC {
Bukkit.getScheduler().runTaskLater(plugin, () ->
playerConnection.sendPacket(packetPlayOutPlayerInfoRemove), 5);
playerConnection.sendPacket(packetPlayOutPlayerInfoRemove), 50);
}
@Override
nms/v1_9_R2/src/main/java/net/jitse/npclib/nms/v1_9_R2/NPC_v1_9_R2.java
+2 -5
View File
@@ -13,7 +13,6 @@ import net.jitse.npclib.nms.v1_9_R2.packets.PacketPlayOutScoreboardTeamWrapper;
import net.jitse.npclib.skin.Skin;
import net.minecraft.server.v1_9_R2.*;
import org.bukkit.Bukkit;
import org.bukkit.Location;
import org.bukkit.craftbukkit.v1_9_R2.entity.CraftPlayer;
import org.bukkit.entity.Player;
import org.bukkit.plugin.java.JavaPlugin;
@@ -37,9 +36,7 @@ public class NPC_v1_9_R2 extends NPC {
}
@Override
public void create(Location location) {
this.location = location;
public void createPackets() {
this.hologram = new Hologram(location.clone().subtract(0, 0.5, 0), lines);
hologram.generatePackets(false);
@@ -84,7 +81,7 @@ public class NPC_v1_9_R2 extends NPC {
Bukkit.getScheduler().runTaskLater(plugin, () ->
playerConnection.sendPacket(packetPlayOutPlayerInfoRemove), 5);
playerConnection.sendPacket(packetPlayOutPlayerInfoRemove), 50);
}
@Override