Jona123/NPCLib
0
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Implement proper multi-threading

Browse Source 
Replace raw Thread instantiation with a thread pool.
This commit is contained in:
A248
2019-11-23 10:56:28 -05:00
committed by GitHub
parent b5621816cb
commit f2bc472f6f
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
api/src/main/java/net/jitse/npclib/api/skin/MineSkinFetcher.java
+3 -2
View File
@@ -20,9 +20,10 @@ import java.util.Scanner;
public class MineSkinFetcher { public class MineSkinFetcher {
private static final String MINESKIN_API = "https://api.mineskin.org/get/id/"; private static final String MINESKIN_API = "https://api.mineskin.org/get/id/";
private static final ExecutorService threadPool = Executors.newCachedThreadPool();
public static void fetchSkinFromIdAsync(int id, Callback callback) { public static void fetchSkinFromIdAsync(int id, Callback callback) {
new Thread(() -> { threadPool.execute(() -> {
try { try {
StringBuilder builder = new StringBuilder(); StringBuilder builder = new StringBuilder();
HttpURLConnection httpURLConnection = (HttpURLConnection) new URL(MINESKIN_API + id).openConnection(); HttpURLConnection httpURLConnection = (HttpURLConnection) new URL(MINESKIN_API + id).openConnection();
@@ -50,7 +51,7 @@ public class MineSkinFetcher {
exception.printStackTrace(); exception.printStackTrace();
callback.failed(); callback.failed();
} }
}).start(); });
} }
public interface Callback { public interface Callback {